Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lake fetches caches for unbuilt dependencies #5633

Closed
tydeu opened this issue Oct 7, 2024 · 0 comments · Fixed by #5641
Closed

Lake fetches caches for unbuilt dependencies #5633

tydeu opened this issue Oct 7, 2024 · 0 comments · Fixed by #5641
Assignees
@tydeu
Labels
bug Something isn't working Lake Lake related issue

Comments

@tydeu
Copy link
Member

tydeu commented Oct 7, 2024 •
edited
Loading

Description

Lake builds the package-level extraDep target for package and its dependencies even if no target in one of those dependencies is built. As a result, Lake will attempt to fetch the cache for such dependencies even though no build artifacts from those packages are used (or would be built without the cache). Since Lake will re-attempt to fetch the cache as long as the build directory for a package is missing, the lack of a local build on a fetch failure will cause Lake to re-attempt indefinitely. This breaks --no-build in this situation.

Context

Reported on Zulip (diagnosed at this point in the thread).

Versions

v4.13.0-rc1/v4.13.0-rc3

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
@tydeu tydeu added bug Something isn't working Lake Lake related issue labels Oct 7, 2024
@tydeu tydeu self-assigned this Oct 7, 2024
@tydeu tydeu mentioned this issue Oct 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@tydeu
fix: lake: make package extraDep intransitive (#5641)
7942b9e 
A Lake build of target within a a package will no longer build a
package's dependencies package-level extra targets dependencies. At the
technical level, a package's `extraDep` facet no longer transitively
builds its dependencies' `extraDep` facet.

Closes #5633.
github-actions bot pushed a commit that referenced this issue Oct 19, 2024
@tydeu @github-actions
fix: lake: make package extraDep intransitive (#5641)
d585f52 
A Lake build of target within a a package will no longer build a
package's dependencies package-level extra targets dependencies. At the
technical level, a package's `extraDep` facet no longer transitively
builds its dependencies' `extraDep` facet.

Closes #5633.

(cherry picked from commit 7942b9e)
tydeu added a commit that referenced this issue Oct 19, 2024
@tydeu
fix: lake: make package extraDep intransitive (#5641)
bfd4b64 
A Lake build of target within a a package will no longer build a
package's dependencies package-level extra targets dependencies. At the
technical level, a package's `extraDep` facet no longer transitively
builds its dependencies' `extraDep` facet.

Closes #5633.

(cherry picked from commit 7942b9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tydeu tydeu

Labels
bug Something isn't working Lake Lake related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: lake: make package extraDep intransitive tydeu/lean4
1 participant
@tydeu