fix: lake: make package extraDep intransitive
#5641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
changed the title
extraDep intransitiveextraDep intransitive
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 7, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 7, 2024
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 8, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 8, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.13.0 releases/v4.13.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.13.0
# Create a new branch
git switch --create backport-5641-to-releases/v4.13.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7942b9eaae3b4c57b1069c0107ddca14766e0f43
# Push it to GitHub
git push --set-upstream origin backport-5641-to-releases/v4.13.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.13.0Then, create a pull request where the |
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 7, 2024
This check had been removed (cf #17490 and #17491) since it stopped working temporarily. It seems that it works again! 🐙 (According to a comment on #17491, the fix was apparently in leanprover/lean4#5641)
TobiasLeichtfried
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 21, 2024
This check had been removed (cf #17490 and #17491) since it stopped working temporarily. It seems that it works again! 🐙 (According to a comment on #17491, the fix was apparently in leanprover/lean4#5641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Lake build of target within a a package will no longer build a package's dependencies package-level extra targets dependencies. At the technical level, a package's
extraDepfacet no longer transitively builds its dependencies'extraDepfacet.Closes #5633.