chore: indentation before |
#2581
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes indentation before `|` in places where the amount of spaces was not 0 or 2.
eric-wieser
reviewed
Sep 25, 2023
| @@ -187,7 +187,7 @@ instance [One α] [One β] : One (α × β) where | |||
| one := (1, 1) | |||
|
|
|||
| theorem Product.ext : {p q : α × β} → p.1 = q.1 → p.2 = q.2 → p = q | |||
| | (a, b), (c, d) => by simp_all | |||
There was a problem hiding this comment.
This whole file uses four-space indentation
There was a problem hiding this comment.
yes, and curly braces and semi-colons.
Do you propose to not change the indentation before | in this file or to make the style of this file and KyleAlgAbbrev to match the rest of the repo?
There are currently only 69 occurance of by \{\n , one of them seems deliberate (because of the comment "Same example for curly braces and semicolons aficionados")
There was a problem hiding this comment.
I can't speak for the lean4 developers, but I think the most sensible choice is either:
- Leave the file alone (reverting the changes here), adapt the rule to "one indentation level" rather than two spaces
- Make a separate PR to clean up files with four-space indents.
eric-wieser
reviewed
Sep 25, 2023
| @@ -163,7 +163,7 @@ instance [One α] [One β] : One (α × β) where | |||
| one := (1, 1) | |||
|
|
|||
| theorem Product.ext : {p q : α × β} → p.1 = q.1 → p.2 = q.2 → p = q | |||
| | (a, b), (c, d) => by simp_all | |||
| | (a, b), (c, d) => by simp_all | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes indentation before
|in places where the amount of spaces was not 0 or 2.I suppose this is the non-controversial part of #2580. Deciding for either 0 or 2 to make it consistent would be a much larger change.
Put an X in this bracket to confirm you have read the
External Contribution Guidelines.
Please put the link to your
RFCorbugissue here.PRs missing this link will be marked as
missing RFC.RFC: style: number of spaces before
|#2580