fix: make "use `set_option diagnostics true" message conditional on current setting #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent setting It is confusing that the message suggesting to use the `diagnostics` option is given even when the option is already set. This PR makes use of lazy message data to make the message contingent on the option being false. It also tones down the promise that there is any diagonostic information available, since sometimes there is nothing to report. Suggested by Johan Commelin.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
leodemoura
requested review from
TwoFX,
digama0,
kim-em,
Vtec234,
Kha,
leodemoura and
tydeu
as code owners
eric-wieser
reviewed
Oct 1, 2024
Comment on lines
-303
to
+315
| let msg := s!"(deterministic) timeout{atModuleName}, maximum number of heartbeats ({max/1000}) has been reached\nuse `set_option {optionName} <num>` to set the limit\n{useDiagnosticMsg}" | ||
| throw <| Exception.error (← getRef) (MessageData.ofFormat (Std.Format.text msg)) | ||
| throw <| Exception.error (← getRef) m!"\ | ||
| (deterministic) timeout{atModuleName}, maximum number of heartbeats ({max/1000}) has been reached\n\ | ||
| Use `set_option {optionName} <num>` to set the limit.\ | ||
| {useDiagnosticMsg}" |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Fixes #5565, by using tags instead of trying to string match on a `MessageData`. This ends up reverting some unwanted test output changes from #4781 too. This changes `isMaxRecDepth` for good measure too. This was a regression in Lean 4.11.0, so may be worth backporting to 4.12.x, if not also 4.11.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing that the message suggesting to use the
diagnosticsoption is given even when the option is already set. This PR makes use of lazy message data to make the message contingent on the option being false.It also tones down the promise that there is any diagonostic information available, since sometimes there is nothing to report.
Suggested by Johan Commelin.