Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FunInd: omit unused parameters #6330

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Dec 6, 2024

This PR removes unnecessary parameters from the funcion induction
principles. This is a breaking change; broken code can typically be adjusted
simply by passing fewer parameters.

Closes #6320

@nomeata nomeata added the changelog-language Language features, tactics, and metaprograms label Dec 6, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 6, 2024 17:25 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 6, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 6, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 6, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 6, 2024

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 6, 2024
@nomeata nomeata marked this pull request as ready for review December 6, 2024 22:35
@nomeata nomeata requested a review from leodemoura as a code owner December 6, 2024 22:35
@nomeata nomeata added this pull request to the merge queue Dec 6, 2024
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
This PR removes unnecessary parameters from the funcion induction
principles. This is a breaking change; broken code can typically be adjusted
simply by passing fewer parameters.

Part 1, before stage0 update.

Closes #6320
@nomeata nomeata added the release-ci Enable all CI checks for a PR, like is done for releases label Dec 7, 2024
nomeata added a commit that referenced this pull request Dec 7, 2024
This PR removes unnecessary parameters from the funcion induction
principles. This is a breaking change; broken code can typically be adjusted
simply by passing fewer parameters.

Part 2, adjusting after stage0 update.

Closes #6320
@nomeata nomeata force-pushed the joachim/funind-unused-param branch from a46384e to 9304dde Compare December 7, 2024 01:59
@github-actions github-actions bot added the changes-stage0 Contains stage0 changes, merge manually using rebase label Dec 7, 2024
This PR removes unnecessary parameters from the funcion induction
principles. This is a breaking change; broken code can typically be adjusted
simply by passing fewer parameters.

Part 2, adjusting after stage0 update.

Closes #6320
@nomeata nomeata force-pushed the joachim/funind-unused-param branch from 9304dde to a31e935 Compare December 7, 2024 02:13
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 7, 2024 02:36 Inactive
@nomeata nomeata merged commit 6447fda into master Dec 7, 2024
22 checks passed
nomeata added a commit that referenced this pull request Dec 7, 2024
This PR removes unnecessary parameters from the funcion induction
principles. This is a breaking change; broken code can typically be adjusted
simply by passing fewer parameters.

Part 1, before stage0 update.

Closes #6320
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 7, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms changes-stage0 Contains stage0 changes, merge manually using rebase release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional induction principles should prune parmeters
2 participants