-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjustments to the datetime library #6431
Open
algebraic-dev
wants to merge
12
commits into
leanprover:master
Choose a base branch
from
algebraic-dev:datetime-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e68695
fix: linux fallback directories and trim of the path of localdb in linux
algebraic-dev 41784ab
feat: read TZDIR if it's in the environment
algebraic-dev 7f75830
fix: improve error message of parseTZIfFromDisk
algebraic-dev 262ec2d
Merge branch 'master' of github.com:leanprover/lean4 into datetime-fix
algebraic-dev 1e82e8a
fix: timestamp repr
algebraic-dev 7d9cca4
fix: now PlainTime takes leap seconds as argument
algebraic-dev 9d548b4
fix: change readlink -f to realpath
algebraic-dev 653100b
Merge branch 'leanprover:master' into datetime-fix
algebraic-dev 32a25d8
refactor: update src/Std/Time/Time/PlainTime.lean
algebraic-dev 0afbdd9
Merge branch 'master' of github.com:leanprover/lean4 into datetime-fix
algebraic-dev 3faa88e
Merge branch 'datetime-fix' of github.com:algebraic-dev/lean4 into da…
algebraic-dev b8630b5
chore: fix type variable names
algebraic-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider also parameterizing
PlainDateTime
byleap
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I think that it would lead to more complexity in the common user API and more changes to the code.