Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add regression test for issue 5925 #6511

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Jan 2, 2025

The issue #5925 was closed with strong evidence that #6414 fixed it, and @mik-jozef kindly re-minimized their code that fails on 4.15.0-rc1 and found that it indeed works on the currently nightly for 4.16. This PR adds that as a regression test.

This is a draft because it would be good to check that 6414 really is the cause for it working.

The issue 5925 was closed with strong evidence that leanprover#6414 fixed the issue, and @mik-jozef kindly re-minimized their code that fails on 4.15.0-rc1 and found that it indeed works on the currently nightly for 4.16. This PR adds that as a regression test.
@kmill kmill added the changelog-no Do not include this PR in the release changelog label Jan 2, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 2, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 2, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 2, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 3, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants