-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: make isRfl lazy #7719
Open
Kha
wants to merge
3
commits into
leanprover:master
Choose a base branch
from
Kha:push-kuzpnztmxkrl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf: make isRfl lazy #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 29, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 29, 2025
Mathlib CI status (docs):
|
!bench |
Here are the benchmark results for commit ad98e57. |
!bench |
Here are the benchmark results for commit ece4c21.Found no runs to compare against. |
!bench |
Here are the benchmark results for commit ece4c21. Benchmark Metric Change
==================================================================================
- Init.Data.BitVec.Lemmas branch-misses 5.7% (10.2 σ)
- Init.Data.BitVec.Lemmas task-clock 18.3% (23.5 σ)
+ Init.Data.BitVec.Lemmas wall-clock -27.3% (-69.1 σ)
- Init.Data.BitVec.Lemmas re-elab branch-misses 101.3% (564.4 σ)
- Init.Data.BitVec.Lemmas re-elab branches 21.7% (528.0 σ)
- Init.Data.BitVec.Lemmas re-elab instructions 24.3% (451.2 σ)
- Init.Data.BitVec.Lemmas re-elab maxrss 53.4% (16.4 σ)
- Init.Data.BitVec.Lemmas re-elab task-clock 120.0% (195.6 σ)
- Init.Data.BitVec.Lemmas re-elab wall-clock 47.3% (61.7 σ)
+ Init.Data.List.Sublist re-elab -j4 wall-clock -3.6% (-13.9 σ)
- Std.Data.DHashMap.Internal.RawLemmas task-clock 4.2% (139.8 σ)
+ Std.Data.DHashMap.Internal.RawLemmas wall-clock -19.9% (-83.6 σ)
+ bv_decide_large_aig.lean task-clock -4.3% (-22.7 σ)
+ bv_decide_large_aig.lean wall-clock -4.4% (-21.7 σ)
- bv_decide_mul maxrss 1.4% (189.3 σ)
+ lake build no-op wall-clock -9.3% (-22.3 σ)
+ reduceMatch task-clock -1.1% (-12.9 σ)
+ stdlib attribute application -3.4% (-11.1 σ)
- stdlib blocked (unaccounted) 10.2% (1207.6 σ)
- stdlib process pre-definitions 3.7% (18.8 σ)
- stdlib tactic execution 7.8% (12.1 σ)
- stdlib task-clock 1.1% (22.8 σ)
+ stdlib wall-clock -6.1% (-22.1 σ)
+ unionfind task-clock -20.9% (-30.6 σ)
+ unionfind wall-clock -20.9% (-30.6 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.