Completed Hogwild #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
Jun 17, 2024
Comment on lines
15
to
25
| return ( | ||
| <div className="App"> | ||
| <Nav /> | ||
| <PigForm hogs={hogs} allHogs={allHogs} setAllHogs={setAllHogs}/> | ||
| <Filter hogs={hogs} allHogs={allHogs} setAllHogs={setAllHogs} /> | ||
| <Sort allHogs={allHogs} setAllHogs={setAllHogs} hogs={hogs}/> | ||
| <HideHogs allHogs={allHogs} setAllHogs={setAllHogs} hogs={hogs}/> | ||
| <PigList className='ui grid container' hogs={hogs} allHogs={allHogs}/> | ||
| </div> | ||
| ); | ||
| ) | ||
| } |
There was a problem hiding this comment.
Woah what's going on with the spacing here?!
There was a problem hiding this comment.
Thats a great question. I'll go back and clean this up.
Comment on lines
+19
to
+23
| <> | ||
| <button onClick={handleClick}> | ||
| {buttonText} | ||
| </button> | ||
| </> |
There was a problem hiding this comment.
Suggested change
| <> | |
| <button onClick={handleClick}> | |
| {buttonText} | |
| </button> | |
| </> | |
| <button onClick={handleClick}> | |
| {buttonText} | |
| </button> |
Comment on lines
+17
to
+21
| <> | ||
| <button onClick={handleClick}> | ||
| {buttonText} | ||
| </button> | ||
| </> |
Comment on lines
+4
to
+33
| const [newHogName, setNewHogName] = useState('') | ||
| const [newHogSpecialty, setNewHogSpecialty] = useState('') | ||
| const [newHogWeight, setNewHogWeight] = useState('') | ||
| const [newHogGreased, setNewHogGreased] = useState('') | ||
| const [newHogMedal, setNewHogMedal] = useState('') | ||
| const [newHogImg, setNewHogImg] = useState('') | ||
|
|
||
| function handleHogNameChange(event) { | ||
| setNewHogName(event.target.value) | ||
| } | ||
|
|
||
| function handleHogSpecialtyChange(event) { | ||
| setNewHogSpecialty(event.target.value) | ||
| } | ||
|
|
||
| function handleHogWeightChange(event) { | ||
| setNewHogWeight(event.target.value) | ||
| } | ||
|
|
||
| function handleHogGreasedChange(event) { | ||
| setNewHogGreased(event.target.value) | ||
| } | ||
|
|
||
| function handleHogsMedalChange(event) { | ||
| setNewHogMedal(event.target.value) | ||
| } | ||
|
|
||
| function handleHogsImgChange(event) { | ||
| setNewHogImg(event.target.value) | ||
| } |
There was a problem hiding this comment.
If you review the form abstraction lesson you can find a much simpler way to do this.
Comment on lines
+52
to
+59
| <> | ||
| <button onClick={handleNameClick}> | ||
| {sortButtonName} | ||
| </button> | ||
| <button onClick={handleWeightClick}> | ||
| {sortButtonWeight} | ||
| </button> | ||
| </> |
There was a problem hiding this comment.
When you use a fragment, you should still indent the content by 2 spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote components to display, filter, sort, and create new hogs.