Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate search resource selection #13008

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Jan 15, 2025

Summary

  • Integrate search filters panel to lesson resource selection
  • Add a new immersive header to the side panel modal component.
Compartir.pantalla.-.2025-01-15.17_44_57.mp4

References

Closes #12987

Reviewer guidance

  • Edit a lesson
  • Change browser route path from "/lesson" to "lessontemp".
  • Click on "Manage resources".
  • Click on the search button from the first page on the side panel, or from within any topic
  • Play and try any possible combination with different filters, browsing search results topics, browser back/forward buttons navigation, etc.

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jan 15, 2025
@AlexVelezLl AlexVelezLl force-pushed the integrate-search-resource-selection branch from c731c48 to f982e74 Compare January 16, 2025 15:04
@marcellamaki
Copy link
Member

@pcenov - this is not urgent, but depending on how time consuming your laptop reset process is, this could go to the top of your list for Friday or Monday. Thank you!

@pcenov
Copy link
Member

pcenov commented Jan 20, 2025

Hi @AlexVelezLl and @marcellamaki - I confirm that the search is integrated as specified above.

Here are a few general observations based on my testing which can probably be tracked as follow-up issues if not already tracked somewhere else:

  1. We probably need to indicate in a better way within the search panel that there are no channels to import from when there aren't any as currently this is what I see in that case:

2025-01-20_14-45-55

  1. As specified in Figma, when we open the search panel the Category filter should be expanded by default while currently it's not:

category

3 There are quite a few design differences if the current implementation is closely compared to Figma such as the back arrow and the label are not centered, the keywords label should be removed, the icons for the categories are not added etc. Since I am not sure if this is in scope for this PR I am just mentioning it here as a consideration:

differences

  1. When searching by selecting filters it's not immediately clear how the user should proceed the search (the user has to click the search icon next to the empty keywords field). In this case I was expecting to immediately see the filtered results after having applied a filter:
not.clear.how.to.proceed.mp4
  1. When testing the mobile view in Chrome's mobile devices emulator everything looks ok, but when I open the search panel in Chrome on my Samsung Note 10 phone I can only see the 'N resources selected' text and not the "Save & Finish" button as it's covered by the device's taskbar:

2025-01-20_15-44-38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
3 participants