Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Fix Geo Location fields #437

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

strawgate
Copy link
Collaborator

@strawgate strawgate commented Jan 9, 2025

Fixes #436

Host and entity location fields were not working. This moves them to hass.entity.location and host.location from hass.entity.geo.location and host.geo.location.

This also introduces coverage tests for both.

Also removes a couple extra agent fields from the mapping while we're updating the mapping.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
elasticsearch
   __init__.py1421390%29, 50–55, 74, 93, 98, 212, 240–241
   config_flow.py1590100% 
   const.py540100% 
   diagnostics.py80100% 
   encoder.py23291%42, 51
   entity_details.py1130100% 
   errors.py120100% 
   es_datastream_manager.py42197%81
   es_gateway.py1111388%16–18, 20, 89, 120–122, 124, 126, 137, 140, 143
   es_gateway_8.py2256073%36–37, 54, 56–58, 60–61, 63–64, 66, 149, 169, 171, 173, 205, 237–238, 240, 245–246, 248, 264–268, 270, 273–276, 290–291, 308, 311–312, 314, 320–321, 325–326, 342–343, 346–347, 368–369, 375–377, 379–381, 383, 385–387, 389–390
   es_integration.py56885%39–40, 42–43, 96–97, 125–126
   es_publish_pipeline.py4013192%69, 233, 241, 268–269, 278–279, 283–286, 288–289, 291–294, 296–299, 301–304, 366–367, 374–375, 387, 415
   logger.py620100% 
   loop.py520100% 
   system_info.py33584%34–37, 52
   utils.py100100% 
elasticsearch/datastreams
   __init__.py20100% 
   index_template.py20100% 
TOTAL150713391% 

Tests Skipped Failures Errors Time
255 0 💤 0 ❌ 0 🔥 17.729s ⏱️

@strawgate strawgate enabled auto-merge (squash) January 9, 2025 19:04
@strawgate
Copy link
Collaborator Author

@legrego fixed the linting issues and updated the PR description to mention dropping the unused agent fields

@strawgate strawgate merged commit 029fc88 into legrego:main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0] Geo Location is not properly indexed
2 participants