Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @ethersproject/address in place of ethers/lib/utils #782

Conversation

DefiCake
Copy link

@DefiCake DefiCake commented Dec 14, 2023

This is a small contribution. This issue is keeping me from using ethers v6 in conjunction with @lens-protocol/react-native. Because getAddress is getting routed through ethers/lib/utils, it is trying to resolve to the ethers v6 dependency instead of the v5 that the SDK needs.

I couldn't run the tests locally, I think I need some env configuration. Here is hoping that the change is small enough to not break anything.

EDIT. Some further investigation revealed that the direct use of the ethers library should also be removed, so I pushed additional changes

Copy link

height bot commented Dec 14, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Dec 14, 2023

Someone is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: 7d4be82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@lens-protocol/react Patch
@lens-protocol/react-native Patch
@lens-protocol/react-web Patch
@lens-protocol/wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@krzysu
Copy link
Contributor

krzysu commented Dec 14, 2023

hi @DefiCake I see what you mean, I can clean up this PR and take it from here

@krzysu
Copy link
Contributor

krzysu commented Dec 15, 2023

see this PR for complete removal of dependency on ethers5 #787

@DefiCake
Copy link
Author

I will close this PR in favor of yours @krzysu

@DefiCake DefiCake closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants