Skip to content

Commit

Permalink
Fix with order by rake
Browse files Browse the repository at this point in the history
  • Loading branch information
paveg committed Aug 4, 2018
1 parent 89e1b7d commit 16809c1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions lib/lgtm/error_handleable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ module ErrorHandleable
Net::HTTPGatewayTimeOut
].freeze

# validate_response is response validationg
# @param [Net::HTTPxxx] response Net::HTTP responses
# @raise ::Lgtm::Errors::UnexpectedError
# @return [void]
#
def validate_response(response)
case response
when *SERVER_ERRORS
Expand Down
5 changes: 2 additions & 3 deletions lib/lgtm/plugin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,10 @@ class DangerLgtm < Plugin
# Check status report, say lgtm if no violations
# Generates a `markdown` of a lgtm image.
#
# @param [image_url] lgtm image url
# @param [https_image_only] fetching https image only if true
# @param [String] image_url lgtm image url
# @param [Boolean] https_image_only https image only if true
#
# @return [void]
#
def check_lgtm(image_url: nil, https_image_only: false)
return unless status_report[:errors].length.zero? &&
status_report[:warnings].length.zero?
Expand Down

0 comments on commit 16809c1

Please sign in to comment.