Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest V3 Support #160

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Manifest V3 Support #160

wants to merge 3 commits into from

Conversation

Hell-K
Copy link
Contributor

@Hell-K Hell-K commented Aug 31, 2022

  • Migrated the extension to Manifest V3.
  • Options page:
    • Improved the layout slightly.
    • Changed all links to open in a new tab.
    • Fixed some broken GitLab links.
  • Removed old unneeded code.
  • Bumped the extension version to 5.1.0.0.

@gitguardian
Copy link

gitguardian bot commented Aug 31, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Base64 Basic Authentication 3723f8d options/options.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@leonhartX
Copy link
Owner

Thanks for this! will take a look later

@Hell-K
Copy link
Contributor Author

Hell-K commented Sep 3, 2022

Welcome!

I understand that the secret uncovered is actually an old token that I removed from the extension and so it's appearing in the commit and that's why GitGuardian is not completely happy but I don't think it's a problem. I'm sure you must have revoked it a long time ago.

However, I have no idea why the build-and-test is failing. I've personally been using my modified version of the extension and it's working fine so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants