Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for on method & tests #2

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Improvements for on method & tests #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7253918
Added support for client results
maca88 Apr 28, 2024
7348a95
Merge remote-tracking branch 'lepicekmichal/main' into feature/client…
maca88 Apr 30, 2024
57eb3f2
Merge remote-tracking branch 'lepicekmichal/main' into feature/client…
maca88 Apr 30, 2024
274ac19
removed unneeded code
maca88 Apr 30, 2024
5be5301
Added missing inline function with no parameters
maca88 Apr 30, 2024
2e83b4e
Revert "Added missing inline function with no parameters"
maca88 Apr 30, 2024
ded6136
Added required inline on functions to work with no parameters
maca88 Apr 30, 2024
f22ce63
Merge remote-tracking branch 'lepicekmichal/main' into feature/client…
maca88 May 9, 2024
6c81385
Fixed failing unit tests
maca88 May 9, 2024
5971f83
Merge remote-tracking branch 'lepicekmichal/main' into feature/client…
maca88 May 12, 2024
80cf84c
Implemented the concept from C# official library for on method
maca88 May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions signalrkore/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ kotlin {
val commonTest by getting {
dependencies {
implementation(kotlin("test"))
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:1.8.0")
}
}
val jvmMain by getting {
Expand Down
3 changes: 3 additions & 0 deletions signalrkore/src/commonMain/kotlin/eu/lepicekmichal/signalrkore/HttpHubConnectionBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ class HttpHubConnectionBuilder(private val url: String) {
*/
var transportEnum: TransportEnum = TransportEnum.All

internal var transport: Transport? = null

/**
* The [HttpClient] to be used by the [eu.lepicekmichal.signalrkore.HubConnection]
*/
Expand Down Expand Up @@ -72,6 +74,7 @@ class HttpHubConnectionBuilder(private val url: String) {
if (::protocol.isInitialized) protocol else JsonHubProtocol(logger),
handshakeResponseTimeout,
headers.toMap(),
transport,
transportEnum,
json,
logger,
Expand Down
Loading