chore: fix less project ci (#3652)

* chore: fix less ci * fix: add missing semver require * fix: fix the error format and file path * chore: fix error format * chore: fix test snapshot * chore: fix error position
less · Oct 6, 2021 · a10c339 · a10c339
1 parent 8363912
commit a10c339
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 9 deletions.
diff --git a/packages/less/test/index.js b/packages/less/test/index.js
@@ -28,7 +28,8 @@ var testMap = [
         lessTester.testErrors, null],
     [{strictMath: true, strictUnits: true, javascriptEnabled: true}, '../errors/parse/',
         lessTester.testErrors, null],
-
+    [{math: 'strict', strictUnits: true, javascriptEnabled: true}, 'js-type-errors/',
+        lessTester.testTypeErrors, null],
     [{math: 'strict', strictUnits: true, javascriptEnabled: false}, 'no-js-errors/',
         lessTester.testErrors, null],
     [{math: 'strict', dumpLineNumbers: 'comments'}, 'debug/', null,

diff --git a/packages/less/test/less-test.js b/packages/less/test/less-test.js
@@ -1,5 +1,5 @@
 /* jshint latedef: nofunc */
-
+var semver = require('semver');
 var logger = require('../lib/less/logger').default;
 
 var isVerbose = process.env.npm_config_loglevel !== 'concise';
@@ -226,6 +226,31 @@ module.exports = function() {
         });
     }
 
+    // To fix ci fail about error format change in upstream v8 project
+    // https://github.com/v8/v8/commit/c0fd89c3c089e888c4f4e8582e56db7066fa779b
+    // Node 16.9.0+ include this change via https://github.com/nodejs/node/pull/39947 
+    function testTypeErrors(name, err, compiledLess, doReplacements, sourcemap, baseFolder) {
+        const fileSuffix = semver.gte(process.version, 'v16.9.0') ? '-2.txt' : '.txt';
+        fs.readFile(path.join(baseFolder, name) + fileSuffix, 'utf8', function (e, expectedErr) {
+            process.stdout.write('- ' + path.join(baseFolder, name) + ': ');
+            expectedErr = doReplacements(expectedErr, baseFolder, err && err.filename);
+            if (!err) {
+                if (compiledLess) {
+                    fail('No Error', 'red');
+                } else {
+                    fail('No Error, No Output');
+                }
+            } else {
+                var errMessage = err.toString();
+                if (errMessage === expectedErr) {
+                    ok('OK');
+                } else {
+                    difference('FAIL', expectedErr, errMessage);
+                }
+            }
+        });
+    }
+
     // https://github.com/less/less.js/issues/3112
     function testJSImport() {
         process.stdout.write('- Testing root function registry');
@@ -543,6 +568,7 @@ module.exports = function() {
         runTestSetNormalOnly: runTestSetNormalOnly,
         testSyncronous: testSyncronous,
         testErrors: testErrors,
+        testTypeErrors: testTypeErrors,
         testSourcemap: testSourcemap,
         testSourcemapWithoutUrlAnnotation: testSourcemapWithoutUrlAnnotation,
         testImports: testImports,

diff --git a/packages/test-data/errors/eval/javascript-error.less b/packages/test-data/errors/eval/javascript-error.less
diff --git a/packages/test-data/errors/eval/javascript-error.txt b/packages/test-data/errors/eval/javascript-error.txt
diff --git a/packages/test-data/less/js-type-errors/js-type-error-2.txt b/packages/test-data/less/js-type-errors/js-type-error-2.txt
@@ -0,0 +1,4 @@
+SyntaxError: JavaScript evaluation error: 'TypeError: Cannot read properties of undefined (reading 'toJS')' in {path}js-type-error.less on line 2, column 8:
+1 .scope {
+2   var: `this.foo.toJS`;
+3 }
diff --git a/packages/test-data/less/js-type-errors/js-type-error.less b/packages/test-data/less/js-type-errors/js-type-error.less
@@ -0,0 +1,3 @@
+.scope {
+  var: `this.foo.toJS`;
+}
diff --git a/packages/test-data/less/js-type-errors/js-type-error.txt b/packages/test-data/less/js-type-errors/js-type-error.txt
@@ -0,0 +1,4 @@
+SyntaxError: JavaScript evaluation error: 'TypeError: Cannot read property 'toJS' of undefined' in {path}js-type-error.less on line 2, column 8:
+1 .scope {
+2   var: `this.foo.toJS`;
+3 }