-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to accommodate cross-compilation #7
Conversation
@deitch I'm not sure where # build as before
ADD https://github.com/foo/bar.git#v1.2.3 /src/foo
WORKDIR /src/foo
RUN cargo build --release
RUN cargo sbom > sbom.spdx.json is this correct? |
No, not there. It needs to be anywhere in the output image. So if we copy things from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some simplification
README.md
Outdated
|
||
## Usage | ||
|
||
Use this image as a base `FROM` when building in your EVE Dockerfile. For example: | ||
|
||
```Dockerfile | ||
FROM lfedge/eve-rust:1.80.1 AS rust | ||
# we use host tools to avoid emulation and slow builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this all is correct, it also is confusing, while the original example is straightforward to understand. Can we leave the original example, and then add a section for cross-compilation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this all is correct, it also is confusing, while the original example is straightforward to understand. Can we leave the original example, and then add a section for cross-compilation?
ok, I'll create a separate example
ok, my question was about "where it must be located so LK will find it" , I assumed it must be in the / but it seems it doesn't matter |
Signed-off-by: Mikhail Malyshev <[email protected]>
6a000e4
to
08e5528
Compare
No description provided.