Skip to content

Commit

Permalink
Fix: Remove shade deps from tox
Browse files Browse the repository at this point in the history
Shade libs are deprecated therefore no longer required
to be installed. Remove whitespaces in EOL.

Issue-ID: RELENG-4644
Change-Id: I06226186cc80d5cb6da41b35f7a9fdf8309bf32d
Signed-off-by: Anil Belur <[email protected]>
  • Loading branch information
askb committed Mar 21, 2023
1 parent 4457964 commit 0fb44e2
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lftools/openstack/volume.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def _filter_volumes(volumes, days=0):

def list(os_cloud, days=0):
"""List volumes found according to parameters."""
cloud = openstack.connection.from_config(cloud=os_cloud)
cloud = openstack.connection.from_config(cloud=os_cloud)
volumes = cloud.list_volumes()

filtered_volumes = _filter_volumes(volumes, days)
Expand Down
7 changes: 7 additions & 0 deletions releasenotes/notes/remove-shade-deps-0016a8786e94fbe3.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
deprecations:
- |
Shade libs are deprecated therefore no longer required
to be installed.
https://docs.openstack.org/releasenotes/shade/stein.html
1 change: 0 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ ldap =
python-ldap~=3.1.0
openstack =
osc-lib~=2.2.0
shade~=1.27.1

[files]
packages = lftools
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ description = Latest upstream test. Used for what exactly?
basepython = python3
deps = -r{toxinidir}/requirements-test.txt
commands =
pip install -U python-jenkins requests shade
pip install -U python-jenkins requests
pytest

[testenv:license]
Expand Down

0 comments on commit 0fb44e2

Please sign in to comment.