Add the ability to insert deferrable constraints after the table body #57
+70
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlinsley
reviewed
Jun 11, 2025
| @@ -128,17 +128,29 @@ def clean_options | |||
| dump.gsub!(/^(INSERT INTO schema_migrations .*)\n\n/, "\\1\n") | |||
| end | |||
|
|
|||
| if options[:indexes_after_tables] == true | |||
| # Extract indexes, remove comments and place them just after the respective tables | |||
| if options[:meta_tables_after_main] == true | |||
There was a problem hiding this comment.
For backwards comparability it would be better to check both the new and old setting:
if options[:indexes_after_tables] || options[:meta_tables_after_main]
kravcneger
force-pushed
the
feature-deferrable-constraints-after-main
branch
from
70a9507 to
041591a
Compare
kravcneger
force-pushed
the
feature-deferrable-constraints-after-main
branch
from
041591a to
e5d7621
Compare
andyatkinson
reviewed
Jul 9, 2025
| @@ -128,17 +128,29 @@ def clean_options | |||
| dump.gsub!(/^(INSERT INTO schema_migrations .*)\n\n/, "\\1\n") | |||
| end | |||
|
|
|||
| if options[:indexes_after_tables] == true | |||
| # Extract indexes, remove comments and place them just after the respective tables | |||
| if options[:indexes_after_tables] || options[:meta_tables_after_main] | |||
There was a problem hiding this comment.
Do you want to leave a comment to indicate options[:indexes_after_tables] is the old option and is deprecated, and maybe specify a version where it will be removed? We could also add the deprecation announcement into the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guys, at least one type of constraint can be placed after the table definition, just like indexes. It also improves the readability of the schema.