Support for context menus and localization #4
Conversation
|
Apologies @InDIOS, I've been away on holiday. Please give me a few days to catch up. |
There was a problem hiding this comment.
Support for Localization is a good idea, but may need to be submitted as a separate pull request. Please await the outcome of pull request #5.
| @@ -1,5 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| var fs = require('fs'); | |||
| var path = require('path'); | |||
| var vscode = require('vscode'); | |||
| var fileService = require('./libs/fileService'); | |||
There was a problem hiding this comment.
You should be able to use the existing fileService or modify it if necessary, rather then rewrite a lot of its functionality. The 'Open File...' context menu should just add the option of the UI passing a file location to the fileService to open, in addition to the existing default behaviour of passing the current active document file location to the fileService to open activated by Command/CTRL+ALT+O.
There is another pull request #5 with similar functionality. You may wish to wait for the outcome of that to avoid duplicating efforts.
This reverts commit 686e685.
I added some localization messages, please review that are correct.