Merge pull request PrestaShop#21984 from PululuK/improve-vars-name

Improve Link::getProductLink : Avoid short variable names
lfymcc · Nov 18, 2020 · f5a8bd1 · f5a8bd1
2 parents c190ae1 + 6f59337
commit f5a8bd1
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/classes/Link.php b/classes/Link.php
@@ -129,7 +129,7 @@ public function getProductObject($product, $idLang, $idShop)
      * @param string|null $ean13
      * @param int|null $idLang
      * @param int|null $idShop (since 1.5.0) ID shop need to be used when we generate a product link for a product in a cart
-     * @param int|null $ipa ID product attribute
+     * @param int|null $idProductAttribute ID product attribute
      * @param bool $force_routes
      * @param bool $relativeProtocol
      * @param bool $addAnchor
@@ -146,7 +146,7 @@ public function getProductLink(
         $ean13 = null,
         $idLang = null,
         $idShop = null,
-        $ipa = null,
+        $idProductAttribute = null,
         $force_routes = false,
         $relativeProtocol = false,
         $addAnchor = false,
@@ -176,10 +176,10 @@ public function getProductLink(
         }
 
         //Attribute equal to 0 or empty is useless, so we force it to null so that it won't be inserted in query parameters
-        if (empty($ipa)) {
-            $ipa = null;
+        if (empty($idProductAttribute)) {
+            $idProductAttribute = null;
         }
-        $params['id_product_attribute'] = $ipa;
+        $params['id_product_attribute'] = $idProductAttribute;
         if (!$alias) {
             $product = $this->getProductObject($product, $idLang, $idShop);
         }
@@ -241,10 +241,10 @@ public function getProductLink(
             }
             $params['categories'] = implode('/', $cats);
         }
-        if ($ipa) {
+        if ($idProductAttribute) {
             $product = $this->getProductObject($product, $idLang, $idShop);
         }
-        $anchor = $ipa ? $product->getAnchor((int) $ipa, (bool) $addAnchor) : '';
+        $anchor = $idProductAttribute ? $product->getAnchor((int) $idProductAttribute, (bool) $addAnchor) : '';
 
         return $url . $dispatcher->createUrl('product_rule', $idLang, array_merge($params, $extraParams), $force_routes, $anchor, $idShop);
     }