Skip to content

Conversation

roystgnr
Copy link
Member

We have users running up against the 32-character limit, and it looks like we ought to be able to go to 80.

We have users running up against the 32-character limit, and it looks
like we ought to be able to go to 80.
We're no longer truncating these on write or read.
Copy link
Member

@jwpeterson jwpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that all those exo files got bigger even though their contents should not have changed, I guess it's because we are writing more "blank" padding spaces at the end of every string whether we need them or not?

@roystgnr
Copy link
Member Author

I think we are writing more blank padding spaces, but I also added some long subdomain names to the tests that use those files (which was a good idea; just tossing a few exII calls in blind turned out to require a couple bug fixes afterward), so the files should have all changed regardless.

@roystgnr
Copy link
Member Author

The MOOSE test failures I should have anticipated; those are truncated gold files upstream.

The DistributedMesh failures look like a simple mistake to fix.

@moosebuild
Copy link

moosebuild commented Aug 19, 2025

Job Coverage, step Generate coverage on 6a9aebc wanted to post the following:

Coverage

727f46 #4229 6a9aeb
Total Total +/- New
Rate 64.55% 64.54% -0.01% 96.30%
Hits 75863 75863 - 26
Misses 41668 41680 +12 1

Diff coverage report

Full coverage report

This comment will be updated on new commits.

Usually we do this as we read a file or keep things in sync as we
generate a mesh, but there may be cases where we can't do either easily.
Add error handling, and avoid Exodus warnings from invalid calls in
parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants