-
Notifications
You must be signed in to change notification settings - Fork 298
Expand Exodus name limits #4229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
We have users running up against the 32-character limit, and it looks like we ought to be able to go to 80.
We're no longer truncating these on write or read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that all those exo files got bigger even though their contents should not have changed, I guess it's because we are writing more "blank" padding spaces at the end of every string whether we need them or not?
I think we are writing more blank padding spaces, but I also added some long subdomain names to the tests that use those files (which was a good idea; just tossing a few exII calls in blind turned out to require a couple bug fixes afterward), so the files should have all changed regardless. |
The MOOSE test failures I should have anticipated; those are truncated gold files upstream. The DistributedMesh failures look like a simple mistake to fix. |
Usually we do this as we read a file or keep things in sync as we generate a mesh, but there may be cases where we can't do either easily.
Add error handling, and avoid Exodus warnings from invalid calls in parallel.
We have users running up against the 32-character limit, and it looks like we ought to be able to go to 80.