Removed NDEBUG tracking for compiling tests in Release mode #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am preparing this implementation to be distributed as a Debian package. It requires running all the available tests despite the
Debug
orRelease
build type being selected for CMake. The presence ofNDEBUG
definition tracking in the code removes this possibility because the absence of the_DUMMY_PROTO_
section inmultiaddress_protocol_list.h
allows successful compilation only when the tests are not compiled. Otherwise, the following error occurs:This PR proposes removing
NDEBUG
tracking from the code so the tests would be compiled and run whenCMAKE_BUILD_TYPE
is set toRelease
.