Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting @seetadev to py-libp2p maintainer #272

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

dhuseby
Copy link
Contributor

@dhuseby dhuseby commented Feb 5, 2025

Signed-off-by: Dave Grantham [email protected]

Summary

Manu Sheel has been an active contributor to py-libp2p for 6 months and is currently in charge of the effort to add QUIC transport.

Why do you need this?

Promoting him to maintainer increases the overall velocity of the py-libp2p team and shares the review burden created by the significant increase in contributions.

What else do we need to know?

He's a great guy and fun to work with.

DRI: myself
@galargh

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@dhuseby dhuseby requested review from a team as code owners February 5, 2025 17:26
Copy link
Contributor

github-actions bot commented Feb 5, 2025

The following access changes will be introduced as a result of applying the plan:

Access Changes
User seetadev:
  - will join the organization as a [object Object] (remind them to accept the email invitation)
  - will gain maintain permission to py-libp2p
  - will gain maintain permission to py-libp2p-slog
  - will gain maintain permission to py-libp2p-xor

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_membership.this["seetadev"] will be created
  + resource "github_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "seetadev"
    }

  # github_team_membership.this["py-libp2p maintainers:seetadev"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "9705831"
      + username = "seetadev"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

@dhuseby
Copy link
Contributor Author

dhuseby commented Feb 5, 2025

LGTM 🚀

@dhuseby
Copy link
Contributor Author

dhuseby commented Feb 7, 2025

@galargh will you review this please?

@galargh galargh merged commit 30aaed0 into master Feb 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants