We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We've been bitten twice by the broken Scope handling for the shared TCP Listener: #3181 #3142
From: https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcpreuse/listener.go#L198
// Bugs around multiple calls to OpenConnection or InterceptAccept are prevented by the transport // integration tests.
This is clearly not true. So far, we've run into two configurations that we weren't testing for.
Intuitively, we want to pass the scope explicitly between the layers: TCPReuse -> TCP -> Upgrader TCPReuse -> WebSocket -> Upgrader
Currently TCPReuse sets up the Scope for the Upgrader but any wrapping done in the transports hides the Scope.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
We've been bitten twice by the broken Scope handling for the shared TCP Listener: #3181 #3142
From: https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcpreuse/listener.go#L198
This is clearly not true. So far, we've run into two configurations that we weren't testing for.
Intuitively, we want to pass the scope explicitly between the layers:
TCPReuse -> TCP -> Upgrader
TCPReuse -> WebSocket -> Upgrader
Currently TCPReuse sets up the Scope for the Upgrader but any wrapping done in the transports hides the Scope.
The text was updated successfully, but these errors were encountered: