tcpreuse: fix Scope() for *tls.Conn #3181
Merged
+121
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/websocket-tcpreuse-scope
branch
from
ac4f0cb to
87125fc
Compare
sukunrt
commented
Feb 11, 2025
| @@ -17,6 +17,11 @@ func (c connWithScope) Scope() network.ConnManagementScope { | |||
| return c.scope | |||
| } | |||
|
|
|||
| func (c *connWithScope) Close() error { | |||
There was a problem hiding this comment.
This is required for failures in the http tls handshake for wss. The http server closes the connection when handshake fails.
sukunrt
added a commit
that referenced
this pull request
Feb 12, 2025
sukunrt
added a commit
that referenced
this pull request
Feb 12, 2025
sukunrt
added a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another interface embedding bug 😭