fix(dcutr): Fix end to end tests and add legacy behavior flag (default=true) #3044
+1,243
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the side that in the new code will be the Server, can we add a random wait time after which the server will switch the role to Client and initiate the security negotiation? |
MarcoPolo
changed the title
|
Does it need to be random? Could the server wait 3 RTT (it has the estimate) for the client and switch after? |
|
Unfortunately simple timeouts wont work. This is trickier. We need to always start as a Server. Then switch roles after a random wait. This is because when old go nodes and new go nodes interact, they may both assume the Client role, in which case, conn establishment will fail as both the sides assume the Client role. In the new code, if we always assume the role of Server, there will be 3 cases: old go node vs new go node
new go node vs new go node
|
MarcoPolo
force-pushed
the
marco/fix-dcutr-roles
branch
from
97cc0b3 to
3a951e1
Compare
We did the opposite thing of what the spec says to do. This meant that we would fail to hole-punch with rust nodes because both sides we attempt to be the dialer.
MarcoPolo
force-pushed
the
marco/fix-dcutr-roles
branch
from
cc7e359 to
6459ddb
Compare
MarcoPolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this PR sought to migrate away from the legacy behavior. Now it just tests the hole punching behavior using a simulated network. It also adds a flag to control the legacy behavior, but this is set to default to the current behavior.
Most of the code introduced here is related to the new
simconnpackage which lets us create simulated UDP connections for use with the QUIC transport. This lets us set up arbitrary networks to test holepunching. The End to End test now places hosts A and B behind a firewall that requires holepunching for a direct connection.The plan is to merge this PR to actually test holepunching, then fix #3171 by coming up with a migration strategy and use these tests to verify the strategy.