fix: dht find providers stream #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of DHT interop tests libp2p/interop#7 for content routing, I hit a case that was not caught here. However, in the interop repo the
findProvidersis used exactly as we do here in the tests.Basically, as we are still working with the callbacks version of libp2p core, in the
findProviderslogic in the daemon, we receive all the providers from core and return them as a stream (however, we already have all the data). This way, we were waiting for the first message to arrive (BEGIN MESSAGE) and thenfor awaitfor the remaining ones. As we already sent all the messages in the beginning, it seems that the remaining ones do not get into thefor awaitloop.