Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quic): deprecate QUIC draft-29 version support #5786

Merged
merged 22 commits into from
Mar 3, 2025
Merged

feat(quic): deprecate QUIC draft-29 version support #5786

merged 22 commits into from
Mar 3, 2025
+13 −3

Conversation

tesol2y090
Copy link
Contributor

@tesol2y090 tesol2y090 commented Dec 31, 2024 •
edited by dariusc93
Loading

Description

Deprecate support_draft_version field from QUIC protocol.

resolves #3395

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Sorry, something went wrong.

@tesol2y090 tesol2y090 marked this pull request as ready for review December 31, 2024 14:04
@tesol2y090 tesol2y090 mentioned this pull request Dec 31, 2024
Open
4 tasks
dariusc93
dariusc93 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small comment :)

@dariusc93 dariusc93 changed the title feat(quic): deprecate QUIC draft-29 version support chore(quic): deprecate QUIC draft-29 version support Jan 1, 2025
@dariusc93 dariusc93 self-requested a review January 1, 2025 04:27
dariusc93
dariusc93 previously requested changes Jan 1, 2025
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks like you would need to add #[allow(deprecated)] to support_draft_29 too. Could you do that too? :)

@tesol2y090 tesol2y090 requested a review from dariusc93 January 1, 2025 04:46
@elenaf9
Copy link
Contributor

elenaf9 commented Jan 28, 2025 •
edited
Loading

Friendly ping @tesol2y090. The CI still fails because #[allow(deprecated)] hasn't been added to all usages of support_draft_29 yet.

Also: could we use #[expect(..)] instead of #[allow(..)]? It does the same, but additionally warns us once it is not needed anymore.

@elenaf9 elenaf9 closed this Jan 28, 2025
@elenaf9 elenaf9 reopened this Jan 28, 2025
@tesol2y090 tesol2y090 requested a review from elenaf9 February 16, 2025 17:50
elenaf9
elenaf9 reviewed Feb 18, 2025
View reviewed changes
@tesol2y090 tesol2y090 requested a review from elenaf9 February 20, 2025 08:58
@elenaf9 elenaf9 changed the title chore(quic): deprecate QUIC draft-29 version support feat(quic): deprecate QUIC draft-29 version support Feb 21, 2025
@tesol2y090 tesol2y090 requested a review from elenaf9 February 21, 2025 16:40
@tesol2y090 tesol2y090 requested a review from dariusc93 February 22, 2025 08:56
elenaf9
elenaf9 reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts with master need to be resolved, otherwise LGTM,

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

This pull request has merge conflicts. Could you please resolve them @tesol2y090? 🙏

@elenaf9 elenaf9 dismissed dariusc93’s stale review March 3, 2025 05:49

expect(deprecated) has been added where needed.

@elenaf9 elenaf9 added the send-it label Mar 3, 2025
@mergify mergify bot merged commit 09fa853 into libp2p:master Mar 3, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs

@elenaf9 elenaf9

@dariusc93 dariusc93

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quic: don't support draft versions
4 participants
@tesol2y090 @elenaf9 @jxs @dariusc93