chore(gossipsub): add DEFAULT_MAX_TRANSMIT_SIZE const #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
changed the title
diegomrsantos
changed the title
diegomrsantos
changed the title
jxs
changed the title
jxs
reviewed
Mar 4, 2025
| @@ -136,3 +136,5 @@ pub type Rpc = self::types::Rpc; | |||
|
|
|||
| pub type IdentTopic = Topic<self::topic::IdentityHash>; | |||
| pub type Sha256Topic = Topic<self::topic::Sha256Hash>; | |||
|
|
|||
| pub use crate::protocol::DEFAULT_MAX_TRANSMIT_SIZE; | |||
| @@ -5,6 +5,8 @@ | |||
| - Improve `max_messages_per_rpc` consistency by ensuring RPC control messages also adhere to the existing limits. | |||
| See [PR 5826](https://github.com/libp2p/rust-libp2p/pull/5826) | |||
|
|
|||
| - Create `DEFAULT_MAX_TRANSMIT_SIZE` and use it in the code and docs. The main motivation is to fix the incorrect value mentioned in the docs and prevent it from happening again. See [PR 5906](https://github.com/libp2p/rust-libp2p/pull/5906) | |||
There was a problem hiding this comment.
this is more like a chore, we don't need to add a CHANGELOG.md entry
There was a problem hiding this comment.
There's a failure as well https://github.com/libp2p/rust-libp2p/actions/runs/13655713410/job/38174302038
| @@ -61,6 +61,8 @@ pub(crate) const FLOODSUB_PROTOCOL: ProtocolId = ProtocolId { | |||
| kind: PeerKind::Floodsub, | |||
| }; | |||
|
|
|||
| pub const DEFAULT_MAX_TRANSMIT_SIZE: usize = 65536; | |||
There was a problem hiding this comment.
same as above, do we need this to be pub?
There was a problem hiding this comment.
There's a failure otherwise https://github.com/libp2p/rust-libp2p/actions/runs/13655153154/job/38172407946
There was a problem hiding this comment.
That's what I had when it failed 1e72f14
|
This pull request has merge conflicts. Could you please resolve them @diegomrsantos? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create
DEFAULT_MAX_TRANSMIT_SIZEand use it in the code and docs. The main motivation is to fix the incorrect value mentioned in the docs and prevent it from happening again.Notes & open questions
No
Change checklist