fix: rename InsufficientPeers to NoPeersSubscribedToTopic for clarity #5912
+469
−400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khwahish29
changed the title
dariusc93
reviewed
Mar 5, 2025
kamuik16
reviewed
Mar 6, 2025
dariusc93
reviewed
Mar 6, 2025
Done! Please have a look 🚀 |
jxs
reviewed
Mar 7, 2025
dariusc93
previously approved these changes
Mar 8, 2025
mergify
bot
dismissed stale reviews from jxs and dariusc93
Approvals have been dismissed because the PR was updated after the send-it label was applied.
elenaf9
approved these changes
Mar 9, 2025
wowinter13
pushed a commit
to wowinter13/rust-libp2p
that referenced
this pull request
Mar 9, 2025
The `InsufficientPeers` error was unclear about whether it meant no peers were connected at all or no peers were subscribed to the topic. Rename it to `NoPeersSubscribedToTopic` to make it clear that this error occurs when trying to publish to a topic that has no subscribed peers. Fixes libp2p#5907 Pull-Request: libp2p#5912.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
InsufficientPeerserror was unclear about whether it meant no peers were connected at all or no peers were subscribed to the topic. Rename it toNoPeersSubscribedToTopicto make it clear that this error occurs when trying to publish to a topic that has no subscribed peers.Fixes #5907
Change checklist
protocols/gossipsub/CHANGELOG.mdprotocols/gossipsub/Cargo.tomlto 0.48.2