Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove execute_cycles adjustment based on video_count value #250

Closed
wants to merge 1 commit into from

Conversation

andymcca
Copy link

Commenting out this line appears to fix issue #224 with no adverse effects elsewhere, as far as I can see through limited testing on these games and other games in my collection.

@davidgfnet you will know far better than me, but maybe this line is rendered unnecessary following after you implemented DMA sleep mode and taking into account those cycles?

Commenting out this line appears to fix issue libretro#224 with no adverse effects elsewhere, as far as I can see through limited testing on these games and other games in my collection.

@davidgfnet you will know far better than me, but maybe this line is rendered unnecessary following after you implemented DMA sleep mode and taking into account those cycles?
@andymcca
Copy link
Author

Ahhh nope, no good. All this does is stops execute cycles syncing with video_count (or zero, if video_count is negative), so it puts the timing out of whack. It DOES clear up the visuals on all the games in the issue, but it introduces a big speed penalty on the emulator, so not a 'no effect' change and need to understand what the actual issue is otherwise shooting in the dark. Closing.....

@andymcca andymcca closed this May 18, 2024
@andymcca andymcca deleted the patch-1 branch September 15, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant