Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testprocess: More debug logging #11007

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+16 −4
Draft

testprocess: More debug logging #11007

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7275268
testprocess: Update iteration count as (presumably) intended
smcv Sep 30, 2024
a2c3bf0
testprocess: Show log messages as (presumably) intended
smcv Sep 30, 2024
53d9c34
testprocess: Log a message when all data has been written
smcv Sep 30, 2024
d44e805
testprocess: Log on every iteration
smcv Sep 30, 2024
f53f9e9
testprocess: Improve debug logging
smcv Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions test/testprocess.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,8 @@ static int process_testStdinToStdout(void *arg)

total_written = 0;
total_read = 0;
for (;;) {
int log_this_iteration = (iteration_count % 32) == 32;
for (iteration_count = 0; true; iteration_count++) {
bool log_this_iteration = true;
char local_buffer[16 * 4094];
size_t amount_read;
SDL_IOStatus io_status;
Expand All @@ -466,7 +466,10 @@ static int process_testStdinToStdout(void *arg)
}
amount_written = SDL_WriteIO(process_stdin, text_in + total_written, text_in_size - total_written);
if (log_this_iteration) {
SDLTest_Log("SDL_WriteIO() -> %u (%dth time)", (unsigned)amount_written, iteration_count);
SDLTest_Log("SDL_WriteIO() -> %u (%dth time), total written %u",
(unsigned)amount_written,
iteration_count,
(unsigned)(total_written + amount_written));
}
if (amount_written == 0) {
io_status = SDL_GetIOStatus(process_stdin);
Expand All @@ -477,6 +480,12 @@ static int process_testStdinToStdout(void *arg)
}
total_written += amount_written;
SDL_FlushIO(process_stdin);
if (total_written == text_in_size) {
SDLTest_Log("All data written to stdin");
}
else if (total_written > text_in_size) {
SDLTest_Log("Too much data written?!");
}
}

/* FIXME: this needs a rate limit */
Expand All @@ -485,7 +494,10 @@ static int process_testStdinToStdout(void *arg)
}
amount_read = SDL_ReadIO(process_stdout, local_buffer, sizeof(local_buffer));
if (log_this_iteration) {
SDLTest_Log("SDL_ReadIO() -> %u (%dth time)", (unsigned)amount_read, iteration_count);
SDLTest_Log("SDL_ReadIO() -> %u (%dth time), total read %u",
(unsigned)amount_read,
iteration_count,
(unsigned)(total_read + amount_read));
}
if (amount_read == 0) {
io_status = SDL_GetIOStatus(process_stdout);
Expand Down
Loading