Updates and fixes to build_configs #11397
Open
+634
−702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are only used in build_config files that define them themselves, or not used at all.
Those are defined in other build_configs files and used elsewhere in SDL.
Currently, `SDL_DEFAULT_ASSERT_LEVEL` is commented out by CMake when its value is 0, setting the assertions level to the default value instead of disabling them. This change: - defines `SDL_DEFAULT_ASSERT_LEVEL_CONFIGURED` when its value is non-zero. - defines `SDL_DEFAULT_ASSERT_LEVEL`, regardless of its value, when `SDL_DEFAULT_ASSERT_LEVEL_CONFIGURED` is defined.
Makes all macros only used in `#ifdef`s defined as `1` when they exist, instead of the CMake value of the corresponding variable.
I messed up some spacing, so I thought I might as well strip all those unnecessary spaces.
...and that `SDL_VENDOR_INFO` is included in `SDL_REVISION`.
Lzard
force-pushed
the
build-config-updates
branch
from
402151a to
44ae21d
Compare
|
@madebr, can you take a look at this? It mostly looks good to me, I just want a second pair of eyes on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing macro definitions to
SDL_build_config.h.cmake, removes unused ones, changes unneeded@VAR@replacements to1s, and fixes a few little things.Those are issues I came across while working with
SDL_build_config.h.cmakefor a personal project that uses CMake configuration headers, but not CMake itself.