add private definitions to SDL_build_config.h.cmake #12199
+38
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm adding CMake support for some of the private targets, and for them to work with the automatically generated config file all these definitions are needed (well, at least some of them of course).
Maybe the most "controversial" one will be the last conditional include. I made it that way because that allows us to undefine certain automatically detected functions that are incorrectly detected, as well as manually add anything we need, but I'm open to suggestions about how to tackle that (without modifying the main
CMakeLists.txt
which was the whole point).This is not the only thing needed, there are other things I needed but we can discuss them on their respective repos.