x11: Synthesize fullscreen size events on Openbox #12458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openbox doesn't send size events when entering fullscreen, so they must be synthesized. This is not desirable on any other window manager, as it can break fullscreen positioning on multi-monitor configurations.
|
Do we want this on 3.2.x? |
|
It's a bugfix, so yes, and done. |
|
Thanks, works! ❤️ But on LXDE (which uses openbox), if I |
|
I believe that LXDE is a modified version of Openbox, so it was probably updated to send size and position events when toggling fullscreen. I tried other bare-bones window managers like Fluxbox as well, and it was just plain Openbox that had this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openbox doesn't send size or position events when entering fullscreen, so they must be synthesized. This is not desirable on any other window manager that does send size and position information, as it can break fullscreen positioning on multi-monitor configurations.
Fixes libsdl-org/sdl2-compat#393