Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download SDL3 using CMake + support emscripten #5

Merged
merged 5 commits into from
Oct 19, 2024

Conversation

madebr
Copy link
Contributor

@madebr madebr commented May 22, 2024

  • Add a DOWNLOAD_DEPENDENCIES cmake option to download dependencies using CMake itself
  • Convert the example to use SDL event callbacks
  • Build the example with emscripten on ci (I tested the generated .html locally)

You might want to add/fix documentation/comments in places where it is lacking.

The void *appstate argument is not used in the example.
Perhaps it should as an example?

ci: https://github.com/madebr/SDL_helloworld/actions/runs/9184190253

@madebr madebr force-pushed the sdl3-cmake-download branch from 9f2421c to dc710c2 Compare October 19, 2024 19:29
@madebr madebr merged commit 0114ff1 into libsdl-org:main Oct 19, 2024
4 checks passed
@madebr madebr deleted the sdl3-cmake-download branch October 19, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant