Added --debuginfo argument to create debugging information #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namandixit
force-pushed
the
pr-debuginfo
branch
from
97e419b to
7dc707e
Compare
For use with RenderDoc
namandixit
force-pushed
the
pr-debuginfo
branch
from
7dc707e to
6e2fcaf
Compare
madebr
reviewed
Dec 1, 2024
| @@ -137,7 +137,8 @@ extern SDL_DECLSPEC void * SDLCALL SDL_ShaderCross_CompileDXBCFromSPIRV( | |||
| size_t bytecodeSize, | |||
| const char *entrypoint, | |||
| SDL_ShaderCross_ShaderStage shaderStage, | |||
| size_t *size); | |||
| size_t *size, | |||
| bool debugInfoEnabled); | |||
There was a problem hiding this comment.
Do we need a SDL_ShaderCross_CompileFromProperties to avoid breaking the api?
|
I think these parameter lists are getting too long now, we should probably abstract the parameters into an info struct that we can append properties onto to avoid future API breaks. I might just bring this in and then rewrite it after, but I'll think about it. |
|
CI failure indicates some more function signatures need to be changed, not sure why it builds fine on my PC. Maybe I am not enabling the all the flags or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
--debuginfoargument to the CLI andbool debugInfoEnabledparameter to the relevant API to allow the compilation of shader with debugging information embedded in them.Tested using RenderDoc with:
Closes #64