Allow library users to print DXC errors. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
reviewed
Dec 12, 2024
| @@ -835,7 +835,6 @@ static void *SDL_ShaderCross_INTERNAL_CreateShaderFromHLSL( | |||
| &bytecodeSize); | |||
|
|
|||
| if (spirv == NULL) { | |||
| SDL_SetError("%s", "Failed to compile SPIR-V!"); | |||
There was a problem hiding this comment.
Can you add a comment here along the lines of Error has already been set?
There was a problem hiding this comment.
Oh, yes good catch. Done.
photex
force-pushed
the
photex/dxc-errors
branch
from
cac073f to
700e9b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #67 removing this line allows me to print the dxc compiler output.