Disable finding and linking to DXC if SDLSHADERCROSS_DXC is set to OFF
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatcosmonaut
approved these changes
Jan 1, 2025
|
Looks good to me but I want a review from @madebr first. |
madebr
reviewed
Jan 1, 2025
…RCROSS_VENDORED is set to ON
madebr
reviewed
Jan 1, 2025
madebr
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it so that if
SDLSHADERCROSS_DXCis set toOFF, SDL_Shadercross does not try to find and link to DXC. This is particularly useful on macOS where DXIL support is not necessary and we would otherwise have to build DXC from source (1000+ targets) to compile SDL_shadercross.