Support text from utf8 file and customized window size. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhk
commented
Feb 4, 2024
zhk
commented
- Added argument [-windowsize w,h] to specify the windows size.
- added argument [-utf8txtfile pathName] to support message from utf8 file.
- removed [-utf8|-unicode], since the utf8 or unicode text cannot be input from console.
- fixed [-wrapped] display.
- Added argument [-windowsize w,h] to specify the windows size. - added argument [-utf8txtfile pathName] to support message from utf8 file. - removed [-utf8|-unicode], since the utf8 or unicode text cannot be input from console. - fixed [-wrapped] display.
Set window title for showfont
madebr
reviewed
Feb 4, 2024
VisualC/glfont/glfont.vcxproj
Outdated
| @@ -113,6 +113,7 @@ | |||
| <PreprocessorDefinitions>WIN32;NDEBUG;_WINDOWS;HAVE_OPENGL;%(PreprocessorDefinitions)</PreprocessorDefinitions> | |||
| <RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary> | |||
| <WarningLevel>Level3</WarningLevel> | |||
| <AdditionalIncludeDirectories>K:\ProjectsMine\SDL_ttf\external\SDL\include</AdditionalIncludeDirectories> | |||
There was a problem hiding this comment.
Please remove these system-specific lines.
These visual studio projects assume you have the SDL and SDL_ttf repositories checked out next to each other (and built SDL before).
See lines 99-100 (which probably should use ProjectDir instead as we do in SDL3_net
madebr
reviewed
Feb 4, 2024
examples/showfont.c
Outdated
| @@ -47,13 +47,13 @@ typedef enum | |||
|
|
|||
| typedef struct | |||
| { | |||
| SDL_Texture *caption; | |||
| SDL_Texture* caption; | |||
There was a problem hiding this comment.
This is wrong. Can you fix the .clang-format?
madebr
reviewed
Feb 4, 2024
examples/showfont.c
Outdated
| case TextRenderSolid: | ||
| if (wrap) { | ||
| if (wrap) |
There was a problem hiding this comment.
This too?
You might need to update the .clang-format to match the style we use
- Removed system-specific lines in .vcxproj files - Should fixed compilation on other platforms
Set SubSystem for glfont and showfont Console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.