Refactor/peer #20

boecklim · 2024-04-25T08:53:14Z

Ensure that Shutdown() blocks until all go routines are stopped.
Change read retry function: Remove backoff package and ensure wire.ReadMessage() does not block when cancelling
Move integration test to separate package so that docker container is only started when this test runs

peer.go

boecklim added 5 commits April 25, 2024 09:28

BAARC-148: Move integration test

84485ed

BAARC-148: Change log level in tests

1147162

BAARC-148: Ensure tests do not block indefinitely

6ae4edf

BAARC-148: Test shutdown

b791c90

BAARC-148: Stop all go routines at shutdown and wait until finished

bcfc3f0

boecklim marked this pull request as ready for review April 25, 2024 09:02

boecklim self-assigned this Apr 25, 2024

boecklim mentioned this pull request Apr 25, 2024

Change log level of certain logs #19

Closed

icellan requested changes May 14, 2024

View reviewed changes

peer.go Outdated Show resolved Hide resolved

boecklim added 5 commits May 15, 2024 14:32

BAARC-148: Denote write handler instance in logs

cfc979e

BAARC-148: Use wait group in all go routines for waiting until stopped

38a2905

BAARC-148: Cancel all context

a811d1a

BAARC-148: Separate reconnect function

44eb44f

BAARC-148: Rename cancel function

e168693

icellan reviewed May 15, 2024

View reviewed changes

peer.go Outdated Show resolved Hide resolved

peer.go Outdated Show resolved Hide resolved

peer.go Outdated Show resolved Hide resolved

boecklim added 2 commits May 15, 2024 16:14

BAARC-148: Feedback

4afd278

BAARC-148: Pass global context to reader and writer

bee2023

icellan approved these changes May 15, 2024

View reviewed changes

boecklim merged commit 27578a5 into master May 16, 2024
5 checks passed

Provide feedback