Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: local devnet, foundry 1.0, improved logging, VEBO unit tests #947

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

hotfix: local devnet, foundry 1.0, improved logging, VEBO unit tests #947

wants to merge 45 commits into from

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Feb 14, 2025 •
edited
Loading

eddort and others added 21 commits December 11, 2024 14:28
@eddort
feat: initial deploy to local devnet
483b442
@eddort
feat: speed up scratch deployment for local-devnet
e5aa190
@eddort
refactor: add deployed-local-devnet.json to gitignore
ee55926
@tamtamchik
chore: add default pk for local devnet
ce8c268
@eddort
feat: decrease voting time for devnet
2983d01
@eddort
fix: consensusVersion in VEBO defaults
e879318
@eddort
feat: update default params for devnet
ce1e448
@eddort
feat: custom SLOTS_PER_EPOCH support
e622b3b
@Amuhar
fix: change the module type on curated-onchain-v1 for SimpleDVT in th…
6c8bab8 
…e scratch deploy
@Amuhar
fix: vebo access control and deploy tests
cf98121
@Amuhar
feat: vebo gas, submitReportData, happyPath tests
517076e
@Amuhar
fix: submitReportData method tests
8fa4443
@Amuhar
Merge remote-tracking branch 'origin/develop' into feat/val-1556-move…
3ac9843 
…-vebo-legacy-tests
@mkurayan
Merge commit '2d11786ebc1f06165c501fa8e9fecef053e12ab9' into feat/loc…
2c5f189 
…al-devnet

# Conflicts:
#	hardhat.config.ts
@eddort
feat: add block explorer verify params to hh config
2488ef7
@eddort
Merge branch 'feat/local-devnet' of github.com:lidofinance/core into …
be1e2d8 
…feat/local-devnet
@tamtamchik
feat: hardhat based logs
a4bd6b8
@tamtamchik
chore: cleanup logs
3155741
@tamtamchik
chore: refactor
d4a71e2
@tamtamchik
chore: migrate foundry to stable
986cfde
@tamtamchik
Merge pull request #946 from lidofinance/fix/foundry
b0c3352 
chore: migrate foundry to stable
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                316       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   189-190
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91       2  97.80%   138, 315
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3016      29  99.04%

Diff against master

Filename                                              Stmts    Miss  Cover
--------------------------------------------------  -------  ------  -------
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol        0     -89  +97.80%
TOTAL                                                     0     -89  +2.95%

Results for commit: e2b5dfa

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@tamtamchik
Merge pull request #944 from lidofinance/feat/auto-trace
2f28a18 
feat: improve transactions logging
@tamtamchik tamtamchik changed the title hotfix: update foundry setup to 1.0 hotfix: update foundry setup to 1.0 and improve test logging Feb 14, 2025
@tamtamchik tamtamchik changed the title hotfix: update foundry setup to 1.0 and improve test logging hotfix: update foundry setup to 1.0 and improve test logging UX Feb 14, 2025
@tamtamchik tamtamchik changed the title hotfix: update foundry setup to 1.0 and improve test logging UX hotfix: update foundry setup to 1.0, improve test logging UX, VEBO unit tests Feb 14, 2025
@tamtamchik tamtamchik marked this pull request as ready for review February 17, 2025 11:56
@tamtamchik tamtamchik requested a review from a team as a code owner February 17, 2025 11:56
@tamtamchik tamtamchik changed the title hotfix: update foundry setup to 1.0, improve test logging UX, VEBO unit tests hotfix: local devnet, foundry 1.0, improved logging, VEBO unit tests Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tamtamchik @eddort @Amuhar @mkurayan @dramarereg @folkyatina