Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with conflicting set flags in Bash script #969

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ozrg
Copy link

@ozrg ozrg commented Mar 3, 2025

Context

In the Bash script, set -e +u was used to handle errors and undefined variables, but the combination of these flags caused conflicts and unexpected behavior.

Problem

The flags set -e and set -u were not functioning as intended when used together. set -e stops script execution on any error, while set -u triggers an error for undefined variables. This combination led to inconsistent execution, as the script logic was affected by these conflicts.

Solution

I replaced set -e +u with set -eu, which properly handles both error situations and undefined variables without causing conflicts, ensuring that the script runs as expected.

@ozrg ozrg requested a review from a team as a code owner March 3, 2025 10:35
@tamtamchik tamtamchik changed the base branch from master to develop March 7, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant