Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validator exit verifier contract #976

Draft
wants to merge 5 commits into
base: feat/val-1456-tw-vebo-part
Choose a base branch
from
Draft

feat: add validator exit verifier contract #976

wants to merge 5 commits into from
+2,851 −0

Conversation

mkurayan
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 10, 2025
View reviewed changes
contracts/0.8.25/ValidatorExitVerifier.sol Fixed
function unpackExitRequest(
bytes calldata exitRequests,
uint256 exitRequestIndex
) internal pure returns (bytes calldata pubkey, uint256 nodeOpId, uint256 moduleId, uint256 valIndex) {

Check warning

Code scanning / Slither

Write after write Medium

ExitRequests.unpackExitRequest(bytes,uint256).pubkey is written in both
pubkey = PUBLIC_KEY_LENGTH
pubkey = itemOffset + 16
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  --------------------------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.25/ValidatorExitVerifier.sol                        67       3  95.52%   369, 373, 384
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  100.00%
contracts/0.8.25/interfaces/IValidatorsExitBusOracle.sol           0       0  100.00%
contracts/0.8.25/lib/GIndex.sol                                   33      15  54.55%   17, 29, 50, 58-77, 85, 106
contracts/0.8.25/lib/SSZ.sol                                      15       0  100.00%
contracts/0.8.25/lib/Types.sol                                     0       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                317       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               40       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   189-190
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBus.sol                      41       3  92.68%   103, 131, 148
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol               118       2  98.31%   148, 391
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3219      50  98.45%

Diff against master

Filename                                                    Stmts    Miss  Cover
--------------------------------------------------------  -------  ------  --------
contracts/0.8.25/ValidatorExitVerifier.sol                    +67      +3  +95.52%
contracts/0.8.25/interfaces/IStakingRouter.sol                  0       0  +100.00%
contracts/0.8.25/interfaces/IValidatorsExitBusOracle.sol        0       0  +100.00%
contracts/0.8.25/lib/GIndex.sol                               +33     +15  +54.55%
contracts/0.8.25/lib/SSZ.sol                                  +15       0  +100.00%
contracts/0.8.25/lib/Types.sol                                  0       0  +100.00%
contracts/0.8.9/StakingRouter.sol                              +1       0  +100.00%
contracts/0.8.9/WithdrawalVault.sol                           +19       0  +100.00%
contracts/0.8.9/oracle/ValidatorsExitBus.sol                  +41      +3  +92.68%
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol            +27       0  +0.51%
TOTAL                                                        +203     +21  -0.59%

Results for commit: 648ef94

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@TheDZhon
Copy link
Contributor

TheDZhon commented Mar 11, 2025 •
edited
Loading

GM, let's keep in touch for these proofs features 🙏

#932

Here @Jeday and @DiRaiks are baking quite relevant machinery (see SSZ, CLProofVerifier)

@mkurayan mkurayan force-pushed the feat/val-1390-deliver-delayed-proof branch from 8563eab to edb7923 Compare March 11, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkurayan @TheDZhon