fix: ci mainnet integration test

lidofinance · arwer13 · Mar 7, 2025 · Mar 8, 2025 · Mar 9, 2025 · Mar 10, 2025
commit 2fa8d9ad2dd9283465bfd816eb0ec4babe6f22f1
@@ -37,6 +37,8 @@ jobs:
 
       - name: Finalize scratch deployment
         run: yarn hardhat --network local run --no-compile scripts/utils/mine.ts
+        env:
+          RPC_URL: http://localhost:8555
 
       - name: Run integration tests
         run: yarn test:integration

diff --git a/contracts/0.4.24/lib/StakeLimitUtils.sol b/contracts/0.4.24/lib/StakeLimitUtils.sol
 // SPDX-License-Identifier: GPL-3.0

 /* See contracts/COMPILERS.md */
 pragma solidity 0.4.24;

 import {UnstructuredStorage} from "@aragon/os/contracts/common/UnstructuredStorage.sol";

diff --git a/contracts/0.4.24/oracle/LegacyOracle.sol b/contracts/0.4.24/oracle/LegacyOracle.sol
 /* See contracts/COMPILERS.md */
 pragma solidity 0.4.24;

 import "@aragon/os/contracts/apps/AragonApp.sol";

 import "../../common/interfaces/ILidoLocator.sol";

 import "../utils/Versioned.sol";


 interface IAccountingOracle {
diff --git a/contracts/0.4.24/utils/Versioned.sol b/contracts/0.4.24/utils/Versioned.sol
 // SPDX-License-Identifier: GPL-3.0
 pragma solidity 0.4.24;

 import "@aragon/os/contracts/common/UnstructuredStorage.sol";

 /**
 * @title Adapted code of /contracts/0.8.9/utils/Versioned.sol
diff --git a/contracts/0.8.25/utils/UpgradeTemplateV3.sol b/contracts/0.8.25/utils/UpgradeTemplateV3.sol
    event UpgradeFinished();

    // Old upgraded non-proxy contracts
    IBurner public constant _oldBurner = IBurner(0xD15a672319Cf0352560eE76d9e89eAB0889046D3);
    IOracleReportSanityChecker public constant _oldOracleReportSanityChecker = IOracleReportSanityChecker(0x6232397ebac4f5772e53285B26c47914E9461E75);

    // New proxy contracts
    address public constant _accounting = 0x9015957A2210BB8B10e27d8BBEEF8d9498f123eF;
    IVaultHub public constant _vaultHub = IVaultHub(0x9C6c49E1a5108eC5A2111c0b9B62624100d11e3a);

    // New non-proxy contracts
    IBurner public constant _burner = IBurner(0x897945A56464616a525C9e5F11a8D400a72a8f3A);
    IOracleReportSanityChecker public constant _oracleReportSanityChecker = IOracleReportSanityChecker(0x633a7eB9b8912b22f3616013F3153de687F96074);

    // Existing proxies and contracts
        _assertSingleAragonAppImplementation(_aragonAppLidoRepo, _lidoImplementation);
    }

    function _assertSingleAragonAppImplementation(IAragonAppRepo repo, address implementation) internal view {
        (, address actualImplementation, ) = repo.getLatest();
        if (actualImplementation != implementation) {
            revert IncorrectAragonAppImplementation(address(repo), implementation);
        }
    }

    function _assertFinalACL() internal view {
        address agent = _agent;
	// SPDX-License-Identifier: GPL-3.0

	/* See contracts/COMPILERS.md */
	pragma solidity 0.4.24;
Check warning on line 5 in contracts/0.4.24/lib/StakeLimitUtils.sol GitHub Actions / Solhint `Found more than One contract per file. 3 contracts found!`

	import {UnstructuredStorage} from "@aragon/os/contracts/common/UnstructuredStorage.sol";
	/* See contracts/COMPILERS.md */
	pragma solidity 0.4.24;

	import "@aragon/os/contracts/apps/AragonApp.sol";
Check warning on line 7 in contracts/0.4.24/oracle/LegacyOracle.sol GitHub Actions / Solhint `global import of path @aragon/os/contracts/apps/AragonApp.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)`

	import "../../common/interfaces/ILidoLocator.sol";
Check warning on line 9 in contracts/0.4.24/oracle/LegacyOracle.sol GitHub Actions / Solhint `global import of path ../../common/interfaces/ILidoLocator.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)`

	import "../utils/Versioned.sol";
Check warning on line 11 in contracts/0.4.24/oracle/LegacyOracle.sol GitHub Actions / Solhint `global import of path ../utils/Versioned.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)`


	interface IAccountingOracle {
	// SPDX-License-Identifier: GPL-3.0
	pragma solidity 0.4.24;

	import "@aragon/os/contracts/common/UnstructuredStorage.sol";
Check warning on line 5 in contracts/0.4.24/utils/Versioned.sol GitHub Actions / Solhint `global import of path @aragon/os/contracts/common/UnstructuredStorage.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)`

	/**
	* @title Adapted code of /contracts/0.8.9/utils/Versioned.sol
	event UpgradeFinished();

	// Old upgraded non-proxy contracts
	IBurner public constant _oldBurner = IBurner(0xD15a672319Cf0352560eE76d9e89eAB0889046D3);
Check warning on line 101 in contracts/0.8.25/utils/UpgradeTemplateV3.sol GitHub Actions / Solhint `Constant name must be in capitalized SNAKE_CASE`
	IOracleReportSanityChecker public constant _oldOracleReportSanityChecker = IOracleReportSanityChecker(0x6232397ebac4f5772e53285B26c47914E9461E75);
Check warning on line 102 in contracts/0.8.25/utils/UpgradeTemplateV3.sol GitHub Actions / Solhint `Constant name must be in capitalized SNAKE_CASE`

	// New proxy contracts
	address public constant _accounting = 0x9015957A2210BB8B10e27d8BBEEF8d9498f123eF;
Check warning on line 105 in contracts/0.8.25/utils/UpgradeTemplateV3.sol GitHub Actions / Solhint `Constant name must be in capitalized SNAKE_CASE`
	IVaultHub public constant _vaultHub = IVaultHub(0x9C6c49E1a5108eC5A2111c0b9B62624100d11e3a);
Check warning on line 106 in contracts/0.8.25/utils/UpgradeTemplateV3.sol GitHub Actions / Solhint `Constant name must be in capitalized SNAKE_CASE`

	// New non-proxy contracts
	IBurner public constant _burner = IBurner(0x897945A56464616a525C9e5F11a8D400a72a8f3A);
Check warning on line 109 in contracts/0.8.25/utils/UpgradeTemplateV3.sol GitHub Actions / Solhint `Constant name must be in capitalized SNAKE_CASE`
	IOracleReportSanityChecker public constant _oracleReportSanityChecker = IOracleReportSanityChecker(0x633a7eB9b8912b22f3616013F3153de687F96074);

	// Existing proxies and contracts
	_assertSingleAragonAppImplementation(_aragonAppLidoRepo, _lidoImplementation);
	}

	function _assertSingleAragonAppImplementation(IAragonAppRepo repo, address implementation) internal view {
	(, address actualImplementation, ) = repo.getLatest();
	if (actualImplementation != implementation) {
	revert IncorrectAragonAppImplementation(address(repo), implementation);
	}
	}
Check warning Code scanning / Slither Unused return Medium UpgradeTemplateV3._assertSingleAragonAppImplementation(IAragonAppRepo,address) ignores return value by (None,actualImplementation,None) = repo.getLatest()

	function _assertFinalACL() internal view {
	address agent = _agent;