offers: parse invoice and invoice request #3800
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
There was a problem hiding this comment.
Code looks good, but I think we previously discussed this and had decided against introducing a serialization format for invoices and requests. Not sure if things changed since then though? (cc @jkczyz @TheBlueMatt)
There was a problem hiding this comment.
Overall LGTM, leaving a comment
I has a similar code in a bolt12 tool that I am building for ocean that allow to make verification on the offer + invoice. So would be good to have this feature somehow to allow more usable command line tools.
However, it is also possible to leave this to the caller, exposing some minimal information like AsRef and BECH32_HRP if at the moment, rust-lightning does not want to export this kind of serializzation.
|
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
Add the ability to parse and display BOLT12 invoices and invoice requests. This makes it easy for users of LDK to serialize and deserialize BOLT12 invoices and invoice requests.
JssDWt
force-pushed
the
jssdwt-expand-bolt12-parsing
branch
from
96fd362 to
ffed552
Compare
|
Pushed a change to |
Add the ability to parse and display BOLT12 invoices and invoice requests. This makes it easy for users of LDK to serialize and deserialize BOLT12 invoices and invoice requests.