Simplify UpdateFulfillFetch::NewClaim
#3803
Open
+11
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @jkczyz as a reviewer! |
joostjager
force-pushed
the
claim-without-msg
branch
from
cbc4450 to
237259f
Compare
joostjager
commented
May 27, 2025
lightning/src/ln/channel.rs
Outdated
| @@ -1015,7 +1015,7 @@ enum UpdateFulfillFetch { | |||
| NewClaim { | |||
| monitor_update: ChannelMonitorUpdate, | |||
| htlc_value_msat: u64, | |||
| msg: Option<msgs::UpdateFulfillHTLC>, | |||
| update_non_blocked: bool, | |||
There was a problem hiding this comment.
Not 100% sure what to call this. Could invert and simply call it blocked?
There was a problem hiding this comment.
Yeah, I was thinking maybe update_blocked.
joostjager
force-pushed
the
claim-without-msg
branch
2 times, most recently
from
6f094bb to
5ef74c0
Compare
The actual message is not used anywhere.
joostjager
force-pushed
the
claim-without-msg
branch
from
5ef74c0 to
d0288cd
Compare
jkczyz
approved these changes
May 28, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #3801, I discovered that this code can be simplified.