staticaddr: fix deposit recovery deadlock #954
Merged
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
fix-deadlock
branch
3 times, most recently
from
eb832fd to
7bd246e
Compare
hieblmi
force-pushed
the
fix-deadlock
branch
3 times, most recently
from
de3c60e to
8285bc7
Compare
Merged
sputn1ck
reviewed
Jun 16, 2025
| if err != nil { | ||
| log.Errorf("Error sending OnStart event: %v", err) | ||
| } | ||
| go func(fsm *FSM) { |
There was a problem hiding this comment.
I wonder what the tradeoff is between having this in a go func or more asynchronous fsm actions? from what I can tell in effect it is the same?
There was a problem hiding this comment.
But with most recent projects I tend to force tha actions to be asynchronous as this means we can go events only vs listening for channels everywhere where we need to interact with a blocking action
sputn1ck
approved these changes
Jun 16, 2025
starius
approved these changes
Jun 20, 2025
| log.Errorf("Error sending OnStart event: %v", | ||
| err) | ||
| } | ||
| }(fsm) |
There was a problem hiding this comment.
I propose to add a unit test that would fail with the dead-lock before this change and to make sure this goroutine doesn't leak in that test.
There was a problem hiding this comment.
Given that is is a pattern we use frequently I only left a unit-test todo here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a deadlock in the deposit recovery that arises if deposits expired while the client was offline.
Since
recoverDepositsblocks onfsm.SendEvent(ctx, OnRecover, nil)the main run loop never gets a chance to read fromm.finalizedDepositChan.