staticaddr: neutrino fixes #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
reviewed
Jun 23, 2025
|
I pushed another commit |
hieblmi
reviewed
Jun 23, 2025
| @@ -227,15 +227,18 @@ func (m *Manager) recoverWithdrawals(ctx context.Context) error { | |||
| } | |||
|
|
|||
| // Group the deposits by their finalized withdrawal transaction. | |||
| depositsByWithdrawalTx := make(map[*wire.MsgTx][]*deposit.Deposit) | |||
| depositsByWithdrawalTx := make(map[chainhash.Hash][]*deposit.Deposit) | |||
This is needed for neutrino.
Use errgroup to publish each transaction in a separate goroutine. Publishing a transaction can take a while in neutrino mode.
Do not rely on GetActiveDepositsInState reusing the same *wire.MsgTx pointer for a unique transaction.
|
Rebased and pushed another commit with logging fix "staticaddr: fix error formatting in the log". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recovered withdrawal transactions are now published in parallel to speed-up starting Loop.
Also increased the timeout given for this startup (including the withdrawals' recovery) from 10s to 1m.
Also added logging and removed an unused method in an interface.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes